Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(schematics): better ng-update success message #13687

Conversation

devversion
Copy link
Member

  • Instead of just saying "Complete..." we should make clear which ng-update schematic ran. This is necessary because the CDK and Material update runs independently.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 19, 2018
@devversion devversion requested a review from jelbourn as a code owner October 19, 2018 16:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2018
@devversion devversion changed the title refactor(schematics): better success message refactor(schematics): better ng-update success message Oct 19, 2018
* Instead of just saying "Complete..." we should make clear which `ng-update` schematic ran. This is necessary because the CDK and Material update runs independently.
@devversion devversion force-pushed the refactor/schematics-better-success-msg branch from 047dbb4 to 0e8a15c Compare October 19, 2018 16:42
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 19, 2018
@josephperrott josephperrott merged commit 2f15784 into angular:master Oct 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants